search

qubole / kinesis-sql

Kinesis Connector for Structured Streaming
http://www.qubole.com
Apache License 2.0
137 stars 80 forks source link

Make DefaultAWSCredentialsProviderChain available to choose #71

Closed hyeonseop-lee closed 4 years ago

hyeonseop-lee commented 4 years ago

I found that with current implementation user doesn't have option to choose to use DefaultAWSCredentialsProviderChain. I think current behavior is bit odd: developers familiar with AWS SDK will expect applications to use default provider chain by default, not instance profile credentials.

I added new option awsUseInstanceProfile to choose whether to use instance profile credentials and set the default value to true to not affect the current default behavior. I also updated relevant docs.

itsvikramagr commented 4 years ago

Thanks for the PR @protos37. This is a very good enhancement. Will review and merge it.

hyeonseop-lee commented 4 years ago

@itsvikramagr Sure. Will push commits shortly.