search

quen0n / FipperZero-DHT-Monitor

Flipper Zero plugin for monitoring air temperature and humidity using DHT11 and DHT22 (AM2302/AM2301) sensors
37 stars 0 forks source link

Build fail: Undeclared InputKeyMAX #1

Closed ase1590 closed 2 years ago

ase1590 commented 2 years ago

The following error occurs on build with Official firmware 0.7

CC      applications/plugins/FipperZero-DHT-Monitor-1.1/quenon_dht_mon.c
applications/plugins/FipperZero-DHT-Monitor-1.1/quenon_dht_mon.c: In function 'quenon_dht_mon_app':
applications/plugins/FipperZero-DHT-Monitor-1.1/quenon_dht_mon.c:437:26: error: 'InputKeyMAX' undeclared (first use in this function); did you mean 'InputKey'?
  437 |                     case InputKeyMAX:
      |                          ^~~~~~~~~~~
      |                          InputKey
ase1590 commented 2 years ago

Also of note, against official when compiled after taking out InputKeyMax, FBT reports the following:

quenon_dht_mon.fap: app won't run. Unresolved symbols: {'strtok'}

quen0n commented 2 years ago

On the latest version of the official firmware, I could not reproduce the bug with InputKeyMAX. Problems with {'strcat', 'strtok'} will be solved in the new version of the plugin

Thank you for your message.

ase1590 commented 2 years ago

It looks like my issue is only reproducible when checking out release and compiling against release firmware.

The issue does not present itself against dev branch, so I'm going to say this can be closed as this issue will eventually be solved upstream as it makes it way official release

quen0n commented 2 years ago

https://github.com/quen0n/FipperZero-DHT-Monitor/releases/tag/v1.1owf