quentin452 / OptimizationsAndTweaks

Mod that add some Optimizations/Bugfix/Tweakings for minecraft 1.7.10 and mods
GNU Lesser General Public License v3.0
35 stars 2 forks source link

World corruption and crashes #91

Closed Abalieno closed 9 months ago

Abalieno commented 9 months ago

Modpack

https://github.com/enmumne/Grumpy-GregTech-6

Help isloating the issue

Game log

not enough IDs crash:

[00:00:35] [Server thread/FATAL] [mixin/]: Mixin apply for mod neid failed mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> net.minecraft.world.chunk.storage.AnvilChunkLoader: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @At("INVOKE") on net/minecraft/world/chunk/storage/AnvilChunkLoader::neid$overrideSetByteArray with priority 1000 cannot inject into net/minecraft/world/chunk/storage/AnvilChunkLoader::func_75820_a(Lnet/minecraft/world/chunk/Chunk;Lnet/minecraft/world/World;Lnet/minecraft/nbt/NBTTagCompound;)V merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinAnvilChunkLoader with priority 1000 [PREINJECT Applicator Phase -> mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> Prepare Injections -> -> redirect$bah000$neid$overrideSetByteArray(Lnet/minecraft/nbt/NBTTagCompound;Ljava/lang/String;[BLnet/minecraft/world/chunk/storage/ExtendedBlockStorage;)V -> Prepare] org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/world/chunk/storage/AnvilChunkLoader::neid$overrideSetByteArray with priority 1000 cannot inject into net/minecraft/world/chunk/storage/AnvilChunkLoader::func_75820_a(Lnet/minecraft/world/chunk/Chunk;Lnet/minecraft/world/World;Lnet/minecraft/nbt/NBTTagCompound;)V merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinAnvilChunkLoader with priority 1000 [PREINJECT Applicator Phase -> mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> Prepare Injections -> -> redirect$bah000$neid$overrideSetByteArray(Lnet/minecraft/nbt/NBTTagCompound;Ljava/lang/String;[BLnet/minecraft/world/chunk/storage/ExtendedBlockStorage;)V -> Prepare]

1.8.0 crash:

[main/FATAL] [mixin/]: Mixin apply for mod hodgepodge failed mixins.hodgepodge.early.json:minecraft.MixinWorldGetBlock from mod hodgepodge -> net.minecraft.world.World: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @At("INVOKE") on net/minecraft/world/World::hodgepodge$getBlock with priority 1000 cannot inject into net/minecraft/world/World::func_147439_a(III)Lnet/minecraft/block/Block; merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinWorld with priority 1000 [PREINJECT Applicator Phase -> mixins.hodgepodge.early.json:minecraft.MixinWorldGetBlock from mod hodgepodge -> Prepare Injections -> -> redirect$zmh000$hodgepodge$getBlock(Lnet/minecraft/world/chunk/Chunk;III)Lnet/minecraft/block/Block; -> Prepare] org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/world/World::hodgepodge$getBlock with priority 1000 cannot inject into net/minecraft/world/World::func_147439_a(III)Lnet/minecraft/block/Block; merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinWorld with priority 1000 [PREINJECT Applicator Phase -> mixins.hodgepodge.early.json:minecraft.MixinWorldGetBlock from mod hodgepodge -> Prepare Injections -> -> redirect$zmh000$hodgepodge$getBlock(Lnet/minecraft/world/chunk/Chunk;III)Lnet/minecraft/block/Block; -> Prepare]

Description

Crashes are due to some GTNH mods, I think.

Latest versions were crashing with latest notenoughIDs 1.5.3: https://github.com/GTNewHorizons/NotEnoughIds/releases It was fine up to the menu screen, but it would load the world and then go back to title screen.

The current problem with 1.8.0 instead is some early crash due to mixin. I paste the relevant log above.

ou io y

jl kl

This other problem instead happens with optimizationsandtweaks-V1.7.2

I load into the world normally, but when I exit and enter again, chunks get deleted. I suppose it fails to save them properly on exit.

World corruption still happens on 1.6.9. Only 1.6.7 seems to be working properly.

quentin452 commented 9 months ago

Can you try this? optimizationsandtweaks-V1.8.0-1-7-10.4+43df1c6ec8.zip unzip it

Abalieno commented 9 months ago

Won't run with the old notenoughIDs-1.7.10-1.4.6.jar It sends me back to title screen without loading.

Now I'll try notenoughIDs-1.5.3.jar

Abalieno commented 9 months ago

Nope, both just send me back to title screen.

quentin452 commented 9 months ago

Try making a new world

i got the issue , like can't join world if the bugged jar has been used before in the world

Abalieno commented 9 months ago

Didn't work on new world either (with notenoughIDs-1.5.3.jar)

quentin452 commented 9 months ago

then try changing not enough ids to endlessids

Abalieno commented 9 months ago

Eh, nope. Gives even more issues. Falsepattern stuff is often incompatible with gtnh maintained mods.

quentin452 commented 9 months ago

then idk , you say the 1.6.7 seem to be work correctly, in the dev version i gave, i removed the Mixin i added in V1.6.8 but issues continue to appear for you

Abalieno commented 9 months ago

If 1.6.7 works you'd have to remove changes AFTER that.

quentin452 commented 9 months ago

anyway OptimizationsAndTweaks has configs , try finding the mixin that cause the issue

quentin452 commented 9 months ago

I tried the modpack and for me all is ok with the mod

Abalieno commented 9 months ago

For me notenoughIDs-1.5.3.jar and optimizationsandtweaks-V1.6.7.jar work together. The world loads and there's no corruption.

After 1.6.7 I had to roll back notenoughIDs, or it would send me back to menu screen. But even if 1.6.9 loaded, it had world corruption on reload.

Always restoring from backup.

quentin452 commented 9 months ago

idk , i removed the mixin thats i added in V1.6.8 (in the dev version) so l'ill watch commits

Abalieno commented 9 months ago

I haven't tested 1.6.8, only 1.6.9

quentin452 commented 9 months ago

then you could try disabling one of these mixins , (MixinAnvilChunkLoader has been removed) Capture d’écran_2023-12-15_01-41-59

quentin452 commented 9 months ago

or try the new dev build optimizationsandtweaks-V1.8.0-1-7-10.11+b448503d39.zip unzip it

Abalieno commented 9 months ago

[mixin/]: Mixin apply for mod neid failed mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> net.minecraft.world.chunk.storage.AnvilChunkLoader: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @At("INVOKE") on net/minecraft/world/chunk/storage/AnvilChunkLoader::neid$overrideSetByteArray with priority 1000 cannot inject into net/minecraft/world/chunk/storage/AnvilChunkLoader::func_75820_a(Lnet/minecraft/world/chunk/Chunk;Lnet/minecraft/world/World;Lnet/minecraft/nbt/NBTTagCompound;)V merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinAnvilChunkLoader with priority 1000 [PREINJECT Applicator Phase -> mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> Prepare Injections -> -> redirect$bah000$neid$overrideSetByteArray(Lnet/minecraft/nbt/NBTTagCompound;Ljava/lang/String;[BLnet/minecraft/world/chunk/storage/ExtendedBlockStorage;)V -> Prepare] org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/world/chunk/storage/AnvilChunkLoader::neid$overrideSetByteArray with priority 1000 cannot inject into net/minecraft/world/chunk/storage/AnvilChunkLoader::func_75820_a(Lnet/minecraft/world/chunk/Chunk;Lnet/minecraft/world/World;Lnet/minecraft/nbt/NBTTagCompound;)V merged by fr.iamacat.optimizationsandtweaks.mixins.common.core.MixinAnvilChunkLoader with priority 1000 [PREINJECT Applicator Phase -> mixins.neid.early.json:minecraft.MixinAnvilChunkLoader from mod neid -> Prepare Injections -> -> redirect$bah000$neid$overrideSetByteArray(Lnet/minecraft/nbt/NBTTagCompound;Ljava/lang/String;[BLnet/minecraft/world/chunk/storage/ExtendedBlockStorage;)V -> Prepare]

This is 1.6.8, it sends me to multiplayer screen, for some reason

quentin452 commented 9 months ago

MixinAnvilChunkLoader has been removed (in later version)(DEV)

Abalieno commented 9 months ago

This last one seems to work.

optimizationsandtweaks-V1.8.0-1-7-10.11+b448503d39.jar

quentin452 commented 9 months ago

you mean the new dev build?

edit : ok

quentin452 commented 9 months ago

i can close this?