quince-science / QuinCe

QuinCe is an online tool for processing and quality control of data from scientific instruments, with a primary focus on oceanic data.
https://quince.science
GNU General Public License v3.0
7 stars 8 forks source link

Do not interpolate if interpolation period is longer than 5 minutes #2887

Closed squaregoldfish closed 2 months ago

squaregoldfish commented 3 months ago

At the moment, QuinCe will interpolate any flagged value that's within 5 minutes of a Good value. However, if a period of, say, one hour is flagged, then the five minutes at either end of that period are linearly extrapolated into the flagged period. Since the whole period is bad, this shouldn't happen: the interpolation is only to recover short periods of bad data.

This should work out both of the middle and ends of a dataset.

squaregoldfish commented 3 months ago

Use time between first and last flag as the test

squaregoldfish commented 2 months ago

Is "Only interpolate if you have a before and after" a good approach?

squaregoldfish commented 2 months ago

20230610

squaregoldfish commented 2 months ago

Implementation done. Need to update unit tests.