default-features = false seems to be broken on 0.8

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.76k stars 380 forks source link

default-features = false seems to be broken on 0.8 #1251

Closed Ralith closed 2 years ago

Ralith commented 2 years ago

This Cargo.toml:

[package]
name = "test-quinn"
version = "0.1.0"
edition = "2021"
resolver = "2"

[dependencies]
quinn = { version = "0.8", default-features = false }

is still pulling in rustls, ring, webpki, etc. somehow. quinn's dependency on quinn-proto does specify default-features = false correctly, and quinn doesn't pull in its own optional webpki dep, so I'm at a loss.

daxpedda commented 2 years ago

I believe it's because quinn also pulls in quinn-udp, which in turn is pulling in quinn-proto too, but is missing default-features = false.

Ralith commented 2 years ago

Great catch, thanks!

Ralith commented 2 years ago

Fixed in #1252.