search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Update BBR implementation #1254

Open Ralith opened 2 years ago

Ralith commented 2 years ago

BBR2 has been formally drafted at https://datatracker.ietf.org/doc/html/draft-cardwell-iccrg-bbr-congestion-control. We should update our implementation to match the logic therein.

mogendi commented 1 year ago

Hi @Ralith curious whether this is still a priority for quinn?, the issue has been stale for quite a while.

Ralith commented 1 year ago

Contributions in this direction would be very welcome, but I'm not aware of anyone having immediate plans to take it on. BBR isn't used by default so it's not a critical issue, though congestion control is important and there's lots of room for improvement both here and with the default Cubic implementation.

mogendi commented 1 year ago

@Ralith I could look into handling the move to BBRv2 if it doesn't clash with anyone. Not sure of the laws of the land, should I reuse this issue ?

djc commented 1 year ago

Sure, would be great if you can work on that -- and it's fine to reference this issue.

Ralith commented 1 year ago

Shouldn't be any risk of conflicting efforts. Thanks for having a go at it!

Ralith commented 1 year ago

BBR v3 has been published: https://github.com/google/bbr/tree/v3

@mogendi, are you still interested in working on this?

mogendi commented 1 year ago

@Ralith yes!

Ralith commented 1 year ago

Great, please let us know if there's anything we can do to help you make progress! Feel free to reach out here or on discord.

mogendi commented 1 year ago

will do @Ralith