Don't update remote client CIDs gratuitously

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.76k stars 380 forks source link

Don't update remote client CIDs gratuitously #1294

Closed Ralith closed 2 years ago

Ralith commented 2 years ago

Handling retire_prior_to might have already moved us off the initial CID.

djc commented 2 years ago

That looks like an impressive refactoring. My confidence in my own judgement is still low, but it looks good to me. (And especially with the added documentation and test coverage it feels like a clear improvement.)

Ralith commented 2 years ago

Tidied things up a bit more, in particular to get rid of the dubious Result from update_rem_cid.

djc commented 2 years ago

We should probably timeout on additional reviews and just get this merged. It seems unlikely to be worse given the added tests!