Stop using unbounded channels

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.76k stars 380 forks source link

Stop using unbounded channels #1353

Closed DemiMarie closed 1 year ago

DemiMarie commented 2 years ago

Unbounded channels are an anti-pattern, as they can consume an unbounded amount of memory. It is better to use a bounded channel and handle the case where the channel fills up.

Ralith commented 2 years ago

This would be fixed by https://github.com/quinn-rs/quinn/pull/1219, which is waiting on delayed ACK support to validate performance improvements (@Matthias247, any chance of seeing your WIP for that soon?)

DemiMarie commented 2 years ago

Will this require Quinn to own the threads?

Ralith commented 2 years ago

No.

Ralith commented 1 year ago

Duplicate of https://github.com/quinn-rs/quinn/issues/599.