code still assumes memory layout?

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.76k stars 380 forks source link

code still assumes memory layout? #1391

Closed leshow closed 2 years ago

leshow commented 2 years ago

I saw that the IP types are changing in Rust... I also saw that this library updated in #987 but (and I could be wrong here) I think there's still an issue on recv? As far as I can tell, decode_recv still assumes the layout to be either sockaddr_in or in_addr

If I'm misunderstanding something here, sorry. I am not a libc or unsafe expert by any stretch.

I copied some of the conversion code from mio: https://github.com/tokio-rs/mio/blob/master/src/sys/unix/net.rs#L143

bw-solana commented 2 years ago

Any idea when a release with this fix will be made? We're trying to move our Rust compiler version forward, but everything breaks starting w/ 2022-08-01 without this change

Ralith commented 2 years ago

It looks like this was included in 0.8.4. Is that not working for you?

bw-solana commented 2 years ago

Ah, looks like we're on quinn 0.8.4 but quinn-udp is still on 0.1.1. I can see the changes included in quinn-udp 0.1.3. Thanks!