search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

tag for 0.8.5? #1408

Closed mystenmark closed 2 years ago

mystenmark commented 2 years ago

I noticed that the highest tag on github is 0.8.3, but the current version on crates.io is 0.8.5 - I assume whoever did the release never ran git push --tags - if you wouldn't mind updating the tag that would be great. Thanks!

djc commented 2 years ago

Sorry about that -- pushed the tags.

jxs commented 2 years ago

Cargo.toml also seems outdated, shows 0.8.0

djc commented 2 years ago

That's expected, the changes so far have been in the other crates that the quinn crate depends on.

Ralith commented 2 years ago

Also, that's the Cargo.toml from main, whereas you probably wanted the 0.8.x branch: https://github.com/quinn-rs/quinn/blob/0.8.x/quinn/Cargo.toml#L3

jxs commented 2 years ago

yeah exactly, my confusion was that I added quinn as a dependency and saw 0.8.5 then went to check the features and expected master's Cargo.toml version to match it. Thanks for the clarification :)