quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

`Connection::closed` never terminates if called on an already-closed connection #1411

Closed Ralith closed 1 year ago

Ralith commented 2 years ago

We need to check the current state before waiting.

darioalessandro commented 1 year ago

Hey @Ralith , I am trying to help with this.

Is this the method that hangs?

https://github.com/quinn-rs/quinn/blob/166e0fb60a64b10da9b4aeec5bce9c3c39a057d5/quinn/src/connection.rs#L323-L342

Ralith commented 1 year ago

Thanks for the interest! It looks like this was actually fixed incidentally in 3e2935ff5faced76f71a4f4df9a423f592514272.

darioalessandro commented 1 year ago

Sweet