quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Fix stream open futures sometimes waiting on the wrong notification #1440

Closed Ralith closed 1 year ago

Ralith commented 1 year ago

After a spurious wakeup, Connection::open_uni and open_bi would switch to waiting for notifications about incoming streams, rather than the intended notification about new stream ID flow control budget. This was probably a copy-paste error from poll_accept.

Let's get a patch release out as soon as this is merged.

Ralith commented 1 year ago

(linter complaints addressed in #1439)

djc commented 1 year ago

How hard would it be to add a test for this?

Ralith commented 1 year ago

Science says: not hard.