search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Support external crypto implementations. #1496

Closed nmittler closed 1 year ago

nmittler commented 1 year ago

These changes are needed for the BoringSSL crypto provider (#1488), which will reside in a separate repository.

nmittler commented 1 year ago

@djc I think the visibility changes here make sense, since they're effectively part of the crypto provider API. WDYT?

nmittler commented 1 year ago

@djc I believe I've addressed your concerns. PTAL

nmittler commented 1 year ago

@djc any other comments here? I'd like to get this in quickly, since there will be 2+ follow-on PRs that depend on this. First one is #1501.

nmittler commented 1 year ago

@Ralith did you want to take a look as well?

nmittler commented 1 year ago

@Ralith PTAL

nmittler commented 1 year ago

@djc if I'm reading the lint error correctly, I think it's an existing issue with main. Can you take a look?

djc commented 1 year ago

Yup, new clippy lints from Rust 1.68. Addressed in #1506.

nmittler commented 1 year ago

@djc @Ralith this is blocking https://github.com/quinn-rs/quinn-boring/pull/2. Any chance we can get this in soon?

djc commented 1 year ago

We'll get to it when we get to it -- we're maintaining Quinn on a voluntary basis and you're adding code paths here that are somewhat far out of the core use case. Some patience will be required, just have your downstream code depend on a Git commit for now?

nmittler commented 1 year ago

@djc understood. Thanks!

Ralith commented 1 year ago

Thanks for your patience and persistence here; I've been preoccupied, but I do want to land this.

nmittler commented 1 year ago

@Ralith @djc transport parameters have been reverted. PTAL

nmittler commented 1 year ago

@Ralith @djc thanks for the review! I guess this will be included in the next patch release?

djc commented 1 year ago

Yes -- if you would like one sooner rather than later, can you send a PR to bump the quinn-proto version number?

nmittler commented 1 year ago

@djc thanks ... I've opened https://github.com/quinn-rs/quinn/pull/1520.