Borrow `self` in read_to_end, rather than consuming

quinn-rs / quinn

Async-friendly QUIC implementation in Rust

Apache License 2.0

3.76k stars 380 forks source link

Borrow `self` in read_to_end, rather than consuming #1502

Closed Ralith closed 1 year ago

Ralith commented 1 year ago

Allows RecvStream::stop to be called with custom error codes if ReadToEndError::TooLong is encountered.

See also discussion in #1493.

Ralith commented 1 year ago

No strong feelings; is that the process you'd like to standardize on?

djc commented 1 year ago

My experience is that it's less error-prone, because going back and determining at release time whether there were semver-incompatible changes is a PITA.