Closed link2xt closed 1 year ago
Ugh, how old are these Android phones that you are targeting?
If it's not too much complexity, we're happy to take a PR to enable support on older kernels.
Ugh, how old are these Android phones that you are targeting?
We support Android API 16, so the oldest phones are roughly 10 years old.
I have created a PR for sendmmsg
: https://github.com/quinn-rs/quinn/pull/1504
Fixed by #1504.
I wonder whether the patch merged via https://github.com/quinn-rs/quinn/pull/1504 is worth the trouble it is causing. In other words, I would like to discuss switching back to calling libc::recvmmsg
instead of libc::syscall(libc::SYS_recvmmsg
.
libc::syscall(libc::SYS_recvmmsg
instead of libc::recvmmsg
leads to a SECCOMP panic. See https://github.com/quinn-rs/quinn/pull/1964.quinn
on such old devices? With the security concerns alone, I don't see a use-case outside a completely isolated environment.quinn
support an OS that has been unsupported for 7 years?//CC @link2xt, @flub and @dignifiedquire (since you have been active on https://github.com/deltachat/deltachat-core-rust/pull/4007)
Feel free to drop Android 4 support and bump API level to 21 (Android 5.0) if supporting it is too much trouble. This is what tokio did already and we already bump to API level 19 in https://github.com/deltachat/deltachat-android/pull/3215 Slightly better if you can support Android 4.4 (API level 19), but not a big deal if it is bumped to API level 21.
As for real use cases, Delta Chat has at least a few hundred Android 4 users according to Google Play statistics.
sendmmsg
was added in Linux 3.0 andrecvmmsg
was added in Linux 2.6.33 according to their man pages.It is used in https://github.com/quinn-rs/quinn/blob/389d7ce5067fbef460f0730861340b15f13d4803/quinn-udp/src/unix.rs#L197