quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Warn on unreachable_pub #1526

Closed djc closed 1 year ago

djc commented 1 year ago

I have found this makes it easier to see whether changes affect the public API, which can be hard especially in reviews when context is limited.

djc commented 1 year ago

I'm not a huge fan of the extra verbosity, but the rationale makes sense to me.

Yeah, especially plastering all the fields when a struct has limited visibility is annoyingly repetitive, but I generally really like that you can trust the explicit visibility without having to conduct a reachability analysis in your head.