search

quinn-rs / quinn

Async-friendly QUIC implementation in Rust
Apache License 2.0
3.76k stars 380 forks source link

Reexport rustls types #1600

Closed jonatanzeidler closed 1 year ago

jonatanzeidler commented 1 year ago

This PR makes quinn reexport all rustls types as discussed in #300. This change helps fix the issue described in this example by allowing it to use the reexported types.

jonatanzeidler commented 1 year ago

Please check whether reexporting all of rustls is what we want, as well as whether the location and reexport name make sense to you.

Ralith commented 1 year ago

The convention I've seen elsewhere is to reexport the crate by name at the top level, i.e. pub extern crate rustls; in lib.rs. I think that's a nice clean and intuitive approach.

jonatanzeidler commented 1 year ago

Thanks for the hint. I changed it accordingly, but opted for the pub use syntax, which was already used for the udp crate, too.