search

quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Remove dataset dependent attributes for SMR and biomass gasification from pipelines #3032

Open mabijkerk opened 5 months ago

mabijkerk commented 5 months ago

In https://github.com/quintel/etsource/commit/bcfc262f194d24a0d631d9c1ece120bfcc88ad8b the dataset-specific attributes for SMR and biomass gasification were removed and set to hardcoded values. These values have however not been removed from dataset pipelines. See for example the central_producers of nl2019:

energy_hydrogen_steam_methane_reformer,0.00000000000000E+00,7.50000000000000E+03,,
energy_hydrogen_steam_methane_reformer_ccs,0.00000000000000E+00,7.50000000000000E+03,,
energy_hydrogen_biomass_gasification,0.00000000000000E+00,7.88400000000000E+03,,
energy_hydrogen_biomass_gasification_ccs,0.00000000000000E+00,7.88400000000000E+03,,

It would be good to clean these attributes from the dataset pipelines entirely.

github-actions[bot] commented 3 months ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.