quintoandar / hive-metastore-client

A client for connecting and running DDLs on hive metastore.
Apache License 2.0
52 stars 15 forks source link

Remove exception when getting partition values #64

Closed brenoarosa closed 3 years ago

brenoarosa commented 3 years ago

Why? :open_book:

Code on get_partition_values_from_table was catch a too general exception unnecessarily. It also caused exceptions on the Hive Metastore.

What? :wrench:

Replaces a try-catch statement to an if.

Type of change :file_cabinet:

How everything was tested? :straight_ruler:

Checklist :memo:

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

LucasMMota commented 3 years ago

You can remove the Attention Points warning if it's not relevant in this PR

brenoarosa commented 3 years ago

Nice catch. It LGTM.

Just a doubt, you said in PR's description that "It also caused exceptions on the Hive Metastore.", but it didn't, right? Since the exceptions were being caught by line 384.

This is how we found the issue. While the exception was caught on this client there was a connected unhandled exception on the Hive Mestastore server.