search

quiqueck / BCLib

A library mod for BetterX team mods, developed for Fabric, MC 1.16.4+
https://modrinth.com/mod/bclib
Other
25 stars 24 forks source link

Fix #181 #189

Closed OffsetMonkey538 closed 4 months ago

OffsetMonkey538 commented 4 months ago

Might need testing

coolesding commented 4 months ago

Testing this out in a few minutes, ran into this crash a few minutes ago

KennyDevT commented 4 months ago

I can confirm this works

coolesding commented 4 months ago

I can confirm this works

could you tell me how you built this? ive been failing over and over again because of different things

KennyDevT commented 4 months ago

So Basically you have to make a folder that keeps all the repos separate mine is called BetterXHome. Then you git clone the 1.21 branch of WorldWeaver. After that, you cd into the WorldWeaver Folder and git clone the 1.21 branch of Wunder Lib. Then in the WorldWeaver folder you execute the command gradlew build. Then when its finished cd out of the WorldWeaver and enter this pr branch of BCLib. In the BCLib folder you open the settings.gradle file and set the allowLocalLibInConsoleMode to true.

coolesding commented 4 months ago

Thank you, this seemed to have worked, very silly!

The fix definitely works perfectly fine for me! (although my latest crash deleted my diamond helment :/)

OffsetMonkey538 commented 4 months ago

Yeah, might be worth adding annotations like @Nullable when a method can return null as then your IDE will probably warn about issues like this.

Anyway I think the fix might need to be implemented on older versions as well, but I'm not sure how to do this as I don't want to make multiple PRs for this as that seems annoying and wrong for an issue this small xD

OffsetMonkey538 commented 4 months ago

Seems to be fixed in https://github.com/quiqueck/BCLib/commit/f20b4f2fab1360ecdf90225a12d874aa874d26f7