search

quiqueck / BetterNether

BetterNether Mod
https://modrinth.com/mod/betternether
Other
19 stars 25 forks source link

[Bug] Stripped typo all over code base causing some models not to get loaded properly #204

Open rtm516 opened 3 months ago

rtm516 commented 3 months ago

What happened?

Stripped is typed as striped all over the project causing some models to not parse/load properly.

Flagged this while working on another project that has to parse the resource pack inside the mod jar. Confirmed by doing a code search within the repo.

EG: betternether:item/stalagnate_striped_bark tries to use betternether:block/stalagnate_stripped_bark as a parent model but infact the json is defined as betternether:block/stalagnate_striped_bark

Side note, looks like betternether:block/quartz_glass_framed_noside and betternether:block/quartz_glass_framed_noside_alt don't exist and are also referenced. (Included a log snippet for this aswell)

BetterNether

9.30.0

BCLib

3.30.1

Fabric API

0.91.2

Fabric Loader

0.15.7

Minecraft

1.20.4

Relevant log output

[14:13:01] [Server thread/ERROR] (PackModule) Could not find parent model betternether:block/stalagnate_stripped_bark for model betternether:item/stalagnate_striped_bark
[14:13:01] [Server thread/ERROR] (PackModule) Could not find parent model betternether:block/stalagnate_stripped_log for model betternether:item/stalagnate_striped_log

[14:13:01] [Server thread/ERROR] (PackModule) Could not find parent model betternether:block/quartz_glass_framed_noside_alt for model betternether:block/quartz_glass_framed_pane_black_noside_alt
[14:13:01] [Server thread/ERROR] (PackModule) Could not find parent model betternether:block/quartz_glass_framed_noside for model betternether:block/quartz_glass_framed_pane_white_noside

Other Mods

No response