synchronized lyrics plugin: Support embedded lyrics - Githubissues

quodlibet / quodlibet

Music player and music library manager for Linux, Windows, and macOS

https://quodlibet.readthedocs.io

GNU General Public License v2.0

1.45k stars 224 forks source link

synchronized lyrics plugin: Support embedded lyrics #1989

Open cweiske opened 8 years ago

cweiske commented 8 years ago

The "synchronized lyrics" plugin tries to read an .lrc file with the same name as the current audio file.

MP3's ID3v2 defines the SYLT tag for that: http://id3.org/id3v2.3.0#Synchronised_lyrics.2Ftext
ogg/vorbis files may contain a "kate" stream that contains lyrics https://wiki.xiph.org/OggKate
- katedec -t lrc file.ogg can be used to extract that stream into .lrc format
kid3 has a usable synchronized lyrics editor for mp3; http://kid3.sourceforge.net/

It would be nice if the synchronized lyrics plugin would support reading the synchronized lyrics embedded in the audio files instead of requiring external files.

declension commented 8 years ago

See also #1628

I suggest that ogg/vobis Kate support is excluded from this feature (and another raised in Mutagen as necessary - AIUI it's not supported currently). ~~This ticket can be about ~lyrics support which should be easy enough~~.

EDIT: Sorry, forgot this is synchronised lyrics. Don't think they are quite so easy - would we want another tag, or some kind of magic content-detection to render correctly (plain text vs some synchronised format)

declension commented 8 years ago

Hmm and editing "info" area (see #1068) that deals with lyrics editing should maybe support embedded lyrics, but that's another ticket.

lazka commented 8 years ago

We could also handle lyrics similar to embedded images by provide extra API in AudioFile to load/save. That would mean it's not searchable like tags, but we could load it form multiple sources.

declension commented 8 years ago

@lazka I'm really keen on searchable lyrics if possible, and to an extent this is do-able in QL (e.g ~lyrics=sunshine), but the API idea sounds good; maybe this could be used to retrieve (more like Album Art Downloader then I guess) before embedding or saving to .lrc, etc.

Synchronised ones would make this harder, but I'm sure a data structure that spans .lrc and SYLT and Kate is feasible

tralph3 commented 5 years ago

So, has anything been done to fix this? I spend a lot of time manually syncing my mp3 files' lyrics because I'm a perfectionist. Not being able to use the embbeded ones is stupid, the whole thing is already there, I just need the plugin to read them from the tag itself.

Never mind, did it myself: #3173

elfalem commented 5 years ago

@Nikephor I have always intended to add the option to read LRC formatted lyrics in embedded tags. Your changes in #3173 seems to achieve this. However this issue also mentions reading from the ID3v2 SYLT tag and ogg/vorbis kate streams which requires significant additional work.

cweiske commented 5 years ago

I've not seen Kate streams in ogg/vorbis in the wild, so I would not put any priority on them. However, it is possible to add LRC as a meta datum to ogg/vorbis files - I propose a SYNCLYRICS tag. So it makes sense to add support for embedded LRC, at least in ogg.