qurator-spk / neat

Named entity annotation tool
Apache License 2.0
27 stars 5 forks source link

OCR correction is not being saved in certain cases #35

Closed snmnzl closed 4 years ago

snmnzl commented 4 years ago

We noticed that OCR corrections in combinations of strings with punctuations are not being saved (e.g. "31.") even if they were corrected several times.

cneud commented 4 years ago

fixed in a1bd8afc9dd764c87c24992143632b9aa11b3d07 (cannot reproduce anymore)

snmnzl commented 4 years ago

Thank you for fixing this, the number-punctuation-examples are being saved now and do show when opening the file with Excel or Notepad++ after saving. However, re-opening the saved file in neath does not show the aforementioned corrections (tried on Firefox and Chrome). Example: Donnerstag, 1. Januar)

labusch commented 4 years ago

Right, this bug is a funny one. The CSV parser (papaparse) interprets the string "1." as a floating point number, i.e., 1.0. I'll see how to fix it.