search

qwc-services / qwc-config-generator

QWC Config Generator
2 stars 12 forks source link

Generate config-only services configurations #65

Closed benoitblanc closed 9 months ago

benoitblanc commented 9 months ago

Hi,

As I mentioned in #64 here is a PR to automatically generate config-only services configurations by iterating through all the services in tenantConfig.json.

If some future basic services are added to qwc-services (without specific config), we don't need anymore to add some code in config-generator to generate the right config in OUTPUT_CONFIG_PATH dir.

Please tell me if there is some enhancement to do here.

Thanks

manisandro commented 9 months ago

Thanks, LGTM! Could you add a quick section in the readme, also specifying the config entry skeleton for additional onfigs (which as I read should be something like

{
    "name": "<...>",
    "schema_url":"<...>",
    "config": {...}
}

?

benoitblanc commented 9 months ago

Could you add a quick section in the readme

It is done in the last commit. Thanks for the review

manisandro commented 9 months ago

Thanks!