qwikifiers / qwik-nx

Nx plugin for Qwik
133 stars 24 forks source link

Bump-qwik #234

Open maiieul opened 3 months ago

maiieul commented 3 months ago

What is it?

Description

Installing qwik 1.8.0 fails on qwik-ui. This could potentially solve the issue 🤷

Edit:

The error we're getting is coming from qwik-nx, either when updating to qwik 1.8.0 or to nx 19.5.7:

TypeError: Cannot read properties of undefined (reading 'push') at /home/runner/work/qwik-ui/qwik-ui/node_modules/.pnpm/qwik-nx@2.3.0_bawxiklc23p3w752und6s6mtmi/node_modules/qwik-nx/src/plugins/qwik-nx-vite.plugin.js:36:47 at Generator.next () at fulfilled (/home/runner/work/qwik-ui/qwik-ui/node_modules/.pnpm/tslib@2.6.2/node_modules/tslib/tslib.js:166:62) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

it's trying to push on vendorRoots but it seems that vendorRoots is undefined.

Use cases and why

Screenshots/Demo

Checklist:

dmitry-stepanenko commented 3 months ago

Hey @maiieul , you're bumping only the dev dependency that is only being used inside of this repository. You could bump the peer dependency, but I doubt it will help much, because this project does not really rely on qwik code for anything

I'll be around in roughly an hour, will ping you in discord so we can discuss