r-barnes / faster-unmixer

A faster implementation of the sediment inverse/unmixing scheme proposed in Lipp et al (2021).
5 stars 1 forks source link

Check runtime benchmark values #54

Closed AlexLipp closed 9 months ago

AlexLipp commented 9 months ago

Currently the runtime benchmarking script indicates that the SCS solver is three orders of magnitude faster than ECOS and GUROBI. This is highly improbable and likely indicates a problem with the benchmarking. A possibility is a conversion from ms to seconds somewhere in the processing chain.

runtime_benchmark

AlexLipp commented 9 months ago

runtime_benchmark

This error may simply be due to a manual scaling factor in the plotting section of runtime_benchmark.py. This figure shows the results of the scaling factor of 1e-3 being removed from the SCS plotting commands. Now the runtimes are comparable in time in accordance with other tests.