search

r-hub / rhub

R-hub API client
https://r-hub.github.io/rhub/
Other
354 stars 53 forks source link

Check as CRAN? #644

Closed jonocarroll closed 1 month ago

jonocarroll commented 1 month ago

Apologies if this is handled in rhubv2, but if it is, I could not find it.

Is it possible to set NOT_CRAN=FALSE with the rhubv2? I am preparing a package for submission that requires a lot of network tests, and I've used skip_on_cran() for these to sidestep the potential failures. I have tested locally, but I would also like to use the automated runners if possible.

rhubv1 set check_args = "--as-cran" but I don't see an equivalent for v2.

gaborcsardi commented 1 month ago

Is it possible to set NOT_CRAN=FALSE with the rhubv2?

NOT_CRAN=FALSE is the same as not setting NOT_CRAN at all, and that's how the R-hub v2 containers are running as well.

rhubv1 set check_args = "--as-cran" but I don't see an equivalent for v2.

R-hub v2 always uses --as-cran.

jonocarroll commented 1 month ago

Ah, I do see the --as-cran now. I am confused as to why all of these tests failed - they should have been skipped via skip_on_cran() and are, locally

https://github.com/jonocarroll/ntfy/actions/runs/11583975213

I ran this with rhub::rhub_check(branch = "cran_release") but looking once more at the docs; does this require a non-NULL gh_url?

gaborcsardi commented 1 month ago

Yes, the non-container workflows do set NOT_CRAN=true, through r-lib/actions/setup-r, we should probably change that. Otoh, if you are using a GHA CI, then there isn't really a point in running those, they are the same.

jonocarroll commented 1 month ago

I don't have my own GHA CI set up yet, but I will probably do so - I find the rhub offering to be very convenient and I don't usually have to worry about skipped tests. I would certainly benefit from some runners which are specific to CRAN submissions.

Are any of the container workflows suitable for this?

gaborcsardi commented 1 month ago

I changed the r-hub/actions/setup-r action, so it should not set NOT_CRAN to anything now.

jonocarroll commented 1 month ago

Thank you - I have all green lights now in https://github.com/jonocarroll/ntfy/actions/runs/11592208228 -- I hope this makes sense as a default; it does for me - this service is most helpful to me when releasing a package to CRAN, so mimicking that environment as much as possible is extremely valuable.