Import withr, used by `CRAN_urls()`

r-lib / downlit

Syntax Highlighting and Automatic Linking

https://downlit.r-lib.org

Other

90 stars 22 forks source link

Import withr, used by `CRAN_urls()` #141

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

My guess is that R CMD check doesn't find that you use withr because you memoise CRAN_urls() in the .onLoad(), which significantly changes the body of the function.

DavisVaughan commented 2 years ago

I'm a bit surprised to see a failure in CI related to terra not being able to install. That looks like a "heavy" dependency for suggests.

It looks like it comes from: leaflet -> raster -> terra

I wonder if leaflet could be dropped from Suggests. It is for this one example https://github.com/r-lib/downlit/blob/85c85c51e05fa8460c2b17e8b7302bae44472212/R/evaluate.R#L39-L41

But I guess that example is for testing purposes in combination with pkgdown, so maybe not.

hadley commented 2 years ago

I think it's fine to drop it; we have much better tests in pkgdown.