search

r-lib / later

Schedule an R function or formula to run after a specified period of time.
https://r-lib.github.io/later
Other
137 stars 27 forks source link

Fix Windows include order #178

Closed jeroen closed 11 months ago

jeroen commented 11 months ago

Fixes #177

As explained in this topic the TRUE and FALSE macros get undefined and then redefined in <windows.h>.

The same is done in R_ext/Boolean.h

So we need to include <windows.h> before <Rinternals.h> to get the R version of this macro.

gaborcsardi commented 11 months ago

I can confirm that this fixes installation on arm64 Windows.

wch commented 11 months ago

Thanks! How urgent is a new release?

Do you know if this is this an issue only on arm, and if so, why?

jeroen commented 11 months ago

I would say at your earliest convenience. We are testing packages on win-arm now, so getting this out will unblock cran from building packages that depend on later.

I suspect it is an issue with clang being a bit more strict in coercing int to enum. So it is not specific to arm, but we only use windows clang on arm right now.