r-lib / pkgdown

Generate static html documentation for an R package
https://pkgdown.r-lib.org/
Other
721 stars 335 forks source link

RealFavicon API now returns different set of favicons #2801

Open willgearty opened 4 weeks ago

willgearty commented 4 weeks ago

It looks like the RealFavicon API has changed (probably associated with this), because it no longer returns the same set of favicons. Of the hardcoded filenames in the BS5 template, only "apple-touch-icon.png" is still returned: https://github.com/r-lib/pkgdown/blob/8d9cba19fe597bba170f8d4c99f351491ab4f4d1/inst/BS5/templates/head.html#L8-L13

This then causes the favicon to not render on some devices (e.g., Chrome/Edge on Windows). Here's the website I've recently built for my new R package as an example: https://williamgearty.com/deeptimedata. The list of favicons as built by build_favicons() can be seen here.