818 SAML sign-on behavior with GitHub Enterprise makes install_github() impossible to use for GitHub repos on Enterprise accounts with multiple orgs. Users on one org will be unable to install R packages in public repos on other orgs in the Enterprise account. If remotes would respect auth_token=NULL then that can be put in the install instructions.
Currently when you use install_github(..., auth_token=NULL), remotes does not fully respect the 'request' not to use a PAT and not to use github_pat(). The call to github_pat() (instead of using NULL that was passed in) happens in 2 places.
The changes suggested cause auth_token=NULL to be used consistently, as if there were no PAT at all (which is what is being requested.
Since NULL is what github_pat() returns if there is no PAT stored, it seems like this does not break anything. It simply respects auth_token=NULL.
818 SAML sign-on behavior with GitHub Enterprise makes
install_github()impossible to use for GitHub repos on Enterprise accounts with multiple orgs. Users on one org will be unable to install R packages in public repos on other orgs in the Enterprise account. If remotes would respectauth_token=NULLthen that can be put in the install instructions.Currently when you use
install_github(..., auth_token=NULL), remotes does not fully respect the 'request' not to use a PAT and not to usegithub_pat(). The call togithub_pat()(instead of using NULL that was passed in) happens in 2 places.The changes suggested cause
auth_token=NULLto be used consistently, as if there were no PAT at all (which is what is being requested.Since NULL is what
github_pat()returns if there is no PAT stored, it seems like this does not break anything. It simply respectsauth_token=NULL.