r-lib / svglite

A lightweight svg graphics device for R
https://svglite.r-lib.org
180 stars 39 forks source link

Release svglite 2.1.0 #145

Closed thomasp85 closed 2 years ago

thomasp85 commented 2 years ago

Prepare for release:

Submit to CRAN:

Wait for CRAN...

nx10 commented 2 years ago

Heads up: we currently have a strange unit test error with httpgd on CRAN with R-devel that I can not replicate locally in one of the tests we use from svglite:

https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64-new-UL/httpgd-00check.html

I don't know if this will happen to svglite.

thomasp85 commented 2 years ago

Thanks - yes I have that as well

This is related to systemfonts on the new windows build... something weird with fonts is going on on their new machine

nx10 commented 2 years ago

Thanks for the info. It actually also happens in debian (Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64) and currently prevents us to release a new version.

thomasp85 commented 2 years ago

hmm... I only see it on the new UL windows machine, but otherwise the exact same issue (I assume you have grabbed some unit tests from svglite) https://cran.rstudio.org/web/checks/check_results_svglite.html

nx10 commented 2 years ago

Yes the debian issue came up when I submitted the new version: https://win-builder.r-project.org/incoming_pretest/httpgd_1.3.0_20220103_160727/Debian/00check.log

thomasp85 commented 2 years ago

hmm... based on the last line I think this has actually run on the new windows-UL machine

nx10 commented 2 years ago

I see thanks. I will let you know if I get new information from CRAN.

thomasp85 commented 2 years ago

I'm trying to get hold of a Windows Server 2022 machine to test on...

nx10 commented 2 years ago

Is there any news on your side? I just got an email from CRAN that I should update ASAP. I am considering disabling the test on windows.

thomasp85 commented 2 years ago

Just got that as well - alas I'm off with COVID right now...

I was not able to reproduce it on a fresh Windows Server 2022 so the issue seems local to the CRAN builder 😕

If you can somehow circumvent it in your package I think that would be best for now

nx10 commented 2 years ago

Yes that's probably for the best. I will let you know how I circumvented it if it passes their checks. I wish you a speedy recovery

nx10 commented 2 years ago

Just to let you know: I successfully submitted to CRAN yesterday with the font tests deactivated on windows.