search

r-lib / svglite

A lightweight svg graphics device for R
https://svglite.r-lib.org
180 stars 39 forks source link

Use xml2::xml_find_first() instead of deprecated xml2::xml_find_one() #65

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

The next version of xml2 will be deprecating xml_find_one() in favor of xml_find_first(). The new function is a drop in replacement for the old, and no longer issues a warning when more than one result would be returned.

This pull request also adds a Remotes: hadley/xml2 entry to install the development version of xml2. Once the new version of xml2 is released (2-4 weeks) this should be removed.

codecov-io commented 8 years ago

Current coverage is 93.95%

Merging #65 into master will increase coverage by 0.17%

  1. 2 files (not in diff) in src were modified. more
    • Misses -3
    • Hits -55
  2. File R/utils.R (not in diff) was modified. more
    • Misses -2
    • Partials 0
    • Hits -1
  3. File src/SvgStream.h (not in diff) was created. more
@@           master        #65   diff @@
========================================
  Files           6          7     +1   
  Lines         466        446    -20   
  Methods         0          0          
  Branches        0          0          
========================================
- Hits          437        419    -18   
+ Misses         29         27     -2   
  Partials        0          0

Powered by Codecov. Last updated by f7b3036...c23bdd0

hadley commented 8 years ago

Thanks!