search

r0man / oauth-clj

Clojure OAuth library
95 stars 27 forks source link

Testing / Github revoking OAuth keys #19

Open canweriotnow opened 9 years ago

canweriotnow commented 9 years ago

When I submitted the PR for Github OAuth, I used keys for a dummy test account (typical for OAuth tests). Github has since started scanning repos for active keys and emailed me saying they'd revoked the keys for me since they were found in a public repo, so those tests should now fail.

I'm not sure if/how this will affect other services, but I have two proposals:

  1. Create a credentials.properties.example file that folks can copy to credentials.properties (not checked into source control) and set up their own keys there, or
  2. Use environ and add instructions for setting env vars or values in .lein-env

I prefer environ, but I can also see not wanting to add an external dependency for tests. Let me know if you have a preference or another idea and I'll send a pull request.

r0man commented 9 years ago

Hi @canweriotnow, I'm fine with environ for the tests

canweriotnow commented 9 years ago

Cool, I'll refactor the tests and add instructions and send a PR when I get some downtime.