search

r1m / GSExtended

Grooveshark userscript
MIT License
11 stars 6 forks source link

Emojify and Linkify the whole Grooveshark? #17

Closed ghost closed 9 years ago

ghost commented 10 years ago

Just an idea I got. :p

r1m commented 10 years ago

This is possible. Although, the simplest way to do that is linkify/emojify all DOM nodes, this will not be cheap in term of resources. I leave it to extension that have this only purpose.

A more precise way would be to override view renderer like it is done on chatmessage renderer, but it requires a lot a code reverse. Let's postpone this to later :grinning:

ghost commented 10 years ago

If you think this is too much, we could just add comments to emojify/linkify.

r1m commented 9 years ago

I added linkify to Comments and messages on profile pages

r1m commented 9 years ago

@Mullinx, do you see some other places you want to linkify ?

Mullinx commented 9 years ago

profile and broadcast description

i think if there's an image in the description, it shouldn't embed it to avoid breaking the layout (also, having a gif embedded in the bc description will be annoying).