search

r1m / GSExtended

Grooveshark userscript
MIT License
11 stars 6 forks source link

Smilies issue with quotes #41

Closed Mullinx closed 9 years ago

Mullinx commented 9 years ago

It seems some smilies are getting replaced when you use a quote ( ' or " ) before them. example: "D: = ";D:

also words are affected: "Do = ";Do

OrfeasZ commented 9 years ago

This also happens with other special symbols, like >. My assumption is that there's some kind of HTML escaping going on, converting say " to ", and from then on &quot becomes " and ; remains, followed by the rest of the message, causing it to get parsed as a smiley.

OrfeasZ commented 9 years ago

It should also be noted that special HTML characters are not being escaped. This means that if you type " in chat, you'll see " as the output.

OrfeasZ commented 9 years ago

Other characters that cause this: ', &, <

OrfeasZ commented 9 years ago

An idea would be to fully escape the text (using _.escape) before emojifying it.

r1m commented 9 years ago

_.emojify is bugged I just replicate the VIP feature for non VIP messages. If you are VIP and enter the same text without GSX enabled, it will show the same result

r1m commented 9 years ago

For me it's a wontfix

r1m commented 9 years ago

I should also note that messages from VIP members are not emojified by GSX.