raa0121 / GoBCDice

GoBCDice is BCDice reimplemented by Go.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

加算ロールの成功判定を実装する #25

Closed ochaochaocha3 closed 5 years ago

ochaochaocha3 commented 5 years ago

加算ロールの成功判定(2D6>=8 など)を実装しました。基本的な演算子をひととおり実装したため、README(英語、日本語)にその概要を追記しました。

codecov[bot] commented 5 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.14%. The diff coverage is 68.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   74.52%   74.67%   +0.14%     
==========================================
  Files          35       37       +2     
  Lines        1213     1370     +157     
==========================================
+ Hits          904     1023     +119     
- Misses        243      260      +17     
- Partials       66       87      +21
Impacted Files Coverage Δ
pkg/core/ast/node.go 33.33% <ø> (ø) :arrow_up:
pkg/core/token/token.go 90.9% <ø> (ø) :arrow_up:
pkg/core/command/result.go 60% <0%> (-40%) :arrow_down:
pkg/core/object/object.go 33.33% <0%> (+6.66%) :arrow_up:
pkg/core/lexer/lexer.go 92.15% <100%> (+1.91%) :arrow_up:
pkg/core/evaluator/evaluator.go 70% <100%> (+2.81%) :arrow_up:
pkg/dicebot/testing/testing.go 61.29% <100%> (+11.29%) :arrow_up:
pkg/core/ast/compare.go 27.27% <27.27%> (ø)
pkg/core/ast/infix_expression.go 76.19% <45.45%> (-11.31%) :arrow_down:
pkg/core/ast/prefix_expression.go 77.41% <50%> (+0.49%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78b49d2...42a671e. Read the comment docs.

raa0121 commented 5 years ago

コードはひとまずさらっと見ました。この後挙動確認してみます。