feat: both of the new password inputs are the same, closes #276

raae / pow-app

Take charge of your menstrual cycle with POW! — the privacy-first menstrual cycle journal

https://www.usepow.app/

GNU General Public License v3.0

33 stars 2 forks source link

feat: both of the new password inputs are the same, closes #276 #300

Closed olavea closed 3 years ago

olavea commented 3 years ago

Step 1: Add another input equal to the new password already, but name it something different Step 2: Before calling updateUser make sure the password in both of the new password inputs are the same

If not show an alert and do not update the profile

raae commented 3 years ago

It looks like this is done, done. I will test and approve if it works @olavea

olavea commented 3 years ago

Is 👍 Queen @raae 👑 ?

olavea commented 3 years ago

Take a 👁️ Queen @raae 😺 👍

raae commented 3 years ago

It seems the button does not get disables. It could be something wrong with isUpdating returned from useUser.

recording

Browser metadata

``` Path: /profile/password Browser: Chrome 91.0.4472.77 on Mac OS 10.13.6 Viewport: 1920 x 978 @2x Language: en-GB Cookies: Enabled ``` [View on BrowserStack](https://live.browserstack.com/dashboard#url=https%3A%2F%2Fdeploy-preview-300--pow-app.netlify.app%2Fprofile%2Fpassword&os=OS+X&os_version=High+Sierra&browser=Chrome&browser_version=91.0&resolution=1920x978&speed=1&start=true)

Open Deploy Preview · Mark as Resolved

raae commented 3 years ago

I fixed the isUpdating problem in it's own PR #316 and have merged the updated main in here.

olavea commented 3 years ago

365DaysOfPOWprogramming-day-156_feat- both of the new password inputs are the same, closes #276 #300 -373