search

rabbitmq / erlang-rpm

Latest Erlang/OTP releases packaged as a zero dependency RPM, just enough for running RabbitMQ
https://rabbitmq.com/install-rpm.html
Other
545 stars 117 forks source link

Some releases are missing certain RPMs #92

Closed der-eismann closed 3 years ago

der-eismann commented 3 years ago

Hey everyone,

I just noticed that there are quite a few packages missing on the releases page. Some examples:

I downloaded them from packagecloud for now, so the RPMs are there, they just didn't get pushed to GitHub. It would be great if someone could fix the pipeline.

michaelklishin commented 3 years ago

I will produce and tag 23.0.4 now to see if this can be a timing issue in the pipeline. If so, it will have to wait until the pipeline that produces these packages is 100% automated (including detecting upstream tags). I updated the releases mentioned manually.

michaelklishin commented 3 years ago

The packages uploaded to GitHub as part of a release are taken from Bintray. If some of them are not available, looks like they won't get included:

  - name: tag-package-release-22
    serial: true
    plan:
      - in_parallel:
        - get: ci
          tags: [erlang-elixir]
        - get: centos-7-image
          tags: [erlang-elixir]
        - get: erlang-rpm-src-22
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el6
            - build-erlang-rpm-22-el7
            - build-erlang-rpm-22-el8
        - get: erlang-rpm-package-22-el8-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el8
        - get: erlang-rpm-package-22-el7-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el7
        - get: erlang-rpm-package-22-el6-on-bintray
          tags: [erlang-elixir]
          passed:
            - build-erlang-rpm-22-el6
      - task: format-tag
        tags: [erlang-elixir]
        image: centos-7-image
        file: ci/erlang-rpm/tasks/format-tag.yaml
        input_mapping:
          erlang-rpm-src: erlang-rpm-src-22
      - put: erlang-rpm-src-22
        tags: [erlang-elixir]
        params:
          repository: erlang-rpm-src-22
          tag: tag/tag
          only_tag: true
      - put: erlang-rpm-package-22-on-github
        tags: [erlang-elixir]
        params:
          name: github-release/name
          tag: tag/tag
          body: github-release/body
          globs:
          # A package version on Bintray contains all RPMs (for all CentOS versions)
           - 'erlang-rpm-package-22-el7-on-bintray/erlang/*/el/*/x86_64/erlang-*.rpm'

Concourse's in_parallel step is supposed to fail of any of the steps do. So currently the question is why this does not happen.

michaelklishin commented 3 years ago

According to build logs, the EL8 package is not present in the directory during the upload put step:

18:11:48
creating release 23.0.4
18:11:49
uploading /tmp/build/put/erlang-rpm-package-23-el7-on-bintray/erlang/23/el/6/x86_64/erlang-23.0.4-1.el6.x86_64.rpm
18:11:50
uploading /tmp/build/put/erlang-rpm-package-23-el7-on-bintray/erlang/23/el/7/x86_64/erlang-23.0.4-1.el7.x86_64.rpm

and this is reproducible, which is good news.

der-eismann commented 3 years ago

EL8 packages are present for all newer tags, so I guess this is fixed?

michaelklishin commented 3 years ago

No, I uploaded them manually. Only two out of three RPMs are attached to GitHub releases by Concourse. All three are published to Bintray.

michaelklishin commented 3 years ago

Curiously 23.1.2 does have all three RPMs published by Concourse. It could be a regression in a Concourse resource which has been addressed but it's just a guess at this point. I will reopen this if we see a relapse.

michaelklishin commented 3 years ago

Another set of changes that lead me to believe this has been addressed.