rabbitmq / rabbitmq-stream-dotnet-client

RabbitMQ client for the stream protocol
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html
Other
122 stars 41 forks source link

change default log for ProcessIncomingFrames thread #275

Closed Gsantomaggio closed 1 year ago

Gsantomaggio commented 1 year ago

In a pressure system, the process frame could take more time to be closed. This PR increase a bit the wait time and change the log from Error to Warning because it is not actually an error just a warning.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (b6fa21e) 93.04% compared to head (72a5abf) 93.04%.

:exclamation: Current head 72a5abf differs from pull request most recent head 9403e60. Consider uploading reports for the commit 9403e60 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ======================================= Coverage 93.04% 93.04% ======================================= Files 104 104 Lines 9139 9139 Branches 722 722 ======================================= Hits 8503 8503 + Misses 492 489 -3 - Partials 144 147 +3 ``` | [Impacted Files](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq) | Coverage Δ | | |---|---|---| | [RabbitMQ.Stream.Client/Connection.cs](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq#diff-UmFiYml0TVEuU3RyZWFtLkNsaWVudC9Db25uZWN0aW9uLmNz) | `88.65% <50.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/275/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.