rabbitmq / rabbitmq-stream-dotnet-client

RabbitMQ client for the stream protocol
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html
Other
122 stars 41 forks source link

Removed unused class MyMethodAttribute from Producer.cs #312

Closed TroelsL closed 1 year ago

TroelsL commented 1 year ago

Found an unused internal class in Producer.cs. Unless there is a future use for this, it is not needed. But the naming seems to indicate that this was test code.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (20a43f3) 92.65% compared to head (94d2f20) 92.65%.

:exclamation: Current head 94d2f20 differs from pull request most recent head 02b0571. Consider uploading reports for the commit 02b0571 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #312 +/- ## ========================================== - Coverage 92.65% 92.65% -0.01% ========================================== Files 112 112 Lines 9795 9791 -4 Branches 786 786 ========================================== - Hits 9076 9072 -4 Misses 547 547 Partials 172 172 ``` | [Files Changed](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq) | Coverage Δ | | |---|---|---| | [RabbitMQ.Stream.Client/Reliable/Producer.cs](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq#diff-UmFiYml0TVEuU3RyZWFtLkNsaWVudC9SZWxpYWJsZS9Qcm9kdWNlci5jcw==) | `83.33% <ø> (+1.93%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/312/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.