Closed TroelsL closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
a2e06bf
) 92.79% compared to head (aa87f14
) 92.69%.:exclamation: Current head aa87f14 differs from pull request most recent head 748cc9d. Consider uploading reports for the commit 748cc9d to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you @TroelsL we are looking on it
It looks good to me, but I'd like to hear @Zerpet, who recently worked on https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/pull/305, and I'd like to understand if there is any side effect.
The endpoint is not passed since it is filled when there is the query metadata.
Closing this PR due to a false positive. The change here will have no effect on the current implementation as the value passed set on ClientParameters.EndPoint in the context of StreamSystem is never used.
This fix ensures that the clientParams passed to the StreamSystem matches the one set on the Client (and the one the connection has just been established to).
Fixes an issue where the server is bound to multiple IPs, and it advertises a local IP address over a public one.
Resolves: https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/issues/315