search

rabbitmq / rabbitmq-web-stomp

Provides support for STOMP over WebSockets
Other
89 stars 26 forks source link

Refactoring to compatibility with rabbitmq/rabbitmq-stomp/pull/51 #31

Closed hairyhum closed 8 years ago

hairyhum commented 8 years ago

Fixes #30 @essen can you check please if everything is OK with termination?

essen commented 8 years ago

You can try rabbitmq-web-stomp-examples, there should be 6 examples, if those and the tests work it should be good.

I will try on my side also.

hairyhum commented 8 years ago

At least on my machine it's working.

essen commented 8 years ago

The tests pass here, having issues with examples but that's probably unrelated to this (my changes are probably the cause). If examples work for you I'm OK with this PR. +1

essen commented 8 years ago

Disregard previous comment, I was having issues with my brain, examples work fine for me too.

michaelklishin commented 8 years ago

@hairyhum thank you for stepping in to fix it so quickly.