[rfr] Making SubnetID optional during pool and vip creation

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 185 forks source link

[rfr] Making SubnetID optional during pool and vip creation #607

Closed uruddarraju closed 8 years ago

uruddarraju commented 8 years ago

At eBay, we have made changes to openstack to not have SubnetID mandatory during loadbalancer pool and vip creation. The LbaaS scheduler will find the right LB and the right subnet to create a vip and pool. And hence this can be optional.

This patch is needed to integrate Kubernetes with our internal private cloud LBaaS

cc @ashw7n @khgandhi

coveralls commented 8 years ago

Coverage decreased (-0.01%) to 80.62% when pulling f2e21f09006906a64b69168f497018581c43eeb4 on uruddarraju:optionalSubnet into 0d8599924d296da0f172489ecddf51e4066c329a on rackspace:master.

spothanis commented 8 years ago

@jrperritt could you PTAL

jrperritt commented 8 years ago

This repo is closed to changes. gophercloud/gophercloud is the new repo.

In addition, the options in this repo (and the new one) are for OpenStack proper, not customizations. Custom options may be passed to functions by satisfying the interface of the *OptsBuilder.