Rename request_tests.go to request_test.go

rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592

http://gophercloud.io

Other

456 stars 185 forks source link

Rename request_tests.go to request_test.go #614

Closed MatMaul closed 7 years ago

MatMaul commented 7 years ago

This is the usual convention and it is assumed by several tools like godep.

Needed for trust support in Kubernetes : https://github.com/kubernetes/kubernetes/pull/32111

codevulture commented 7 years ago

+1 godeps failure reason!

MatMaul commented 7 years ago

Seems like the added tests were not call at all, because one is failing :) Next update should fix it.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 80.484% when pulling eb0ce6d2af8fe490af5b3016e80101b21d126c75 on MatMaul:rename_test_file into c90cb954266e1bdd6d1914678fd6909fc5fabbfa on rackspace:master.

strigazi commented 7 years ago

@jrperritt Can you have a look at this?

MatMaul commented 7 years ago

@jrperritt can we merge this please ? we are waiting for it to add trust id to Kubernetes. Thanks !

strigazi commented 7 years ago

@jrperritt Do you have an update? We are blocked in kubernetes side.

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 80.494% when pulling 60916741c8ec228e035f8229aee85452840e2c0d on MatMaul:rename_test_file into c90cb954266e1bdd6d1914678fd6909fc5fabbfa on rackspace:master.