rackspace / gophercloud

A Go SDK for OpenStack. IN FEATURE FREEZE. See Issue #592
http://gophercloud.io
Other
456 stars 185 forks source link

Openstack OS_AUTH_URL cannot be accessed through proxy #628

Open michalmedvecky opened 7 years ago

michalmedvecky commented 7 years ago

My OS_AUTH_URL is accessible only through proxy so I tried to set both http_proxy and HTTP_PROXY env vars, but none of them was accepted by docker-machine (https://github.com/docker/machine/issues/4040 ), which uses gophercloud for Openstack management.

After a long while, I figured out that golang's HTTPClient as used in gophercloud completely ignores those settings and googled that one has to use:

client.HTTPClient.Transport = &http.Transport{Proxy: http.ProxyFromEnvironment}

so go picks http_proxy from env vars.

I've added the mentioned construct to https://github.com/rackspace/gophercloud/blob/master/provider_client.go#L190 and it started working for me.

Can someone responsible pick the right place to add this line to the code?

Thanks