radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
218 stars 62 forks source link

Add some docs + unit tests #115

Closed ret2libc closed 7 years ago

radare commented 7 years ago

looks red

ret2libc commented 7 years ago

As I told you yesterday, with the last commits you just hide the bug of key_len. This new tests show it again (in particular at line https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 )

radare commented 7 years ago

dont push a breaking test without the fix

On 26 Oct 2016, at 10:28, Riccardo Schirone notifications@github.com wrote:

As I told you yesterday, with the last commits you just hide the bug of key_len. This new tests show it again (in particular at line https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 )

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/sdb/pull/115#issuecomment-256282114, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ltJygBkjxPQI_XPbauONlA1Zi9Foks5q3w8RgaJpZM4Kgfut.

ret2libc commented 7 years ago

let's bury our heads in the sand then :P i will write more tests... then we can see how to fix things

radare commented 7 years ago

http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png

On 26 Oct 2016, at 23:19, Riccardo Schirone notifications@github.com wrote:

let's bury our heads in the sand then :P i will write more tests... then we can see how to fix things

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/sdb/pull/115#issuecomment-256480208, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lt1MQHO0TSfBmdRE3EdvutWGFt2_ks5q38PUgaJpZM4Kgfut.

radare commented 7 years ago

can you fix that issue in the same pr?

radare commented 7 years ago

i know this change implies asuming that length doesnt contains the tailing \0

radare commented 7 years ago

tired of waiting. will fix it myself

radare commented 7 years ago

see https://github.com/radare/sdb/commit/2d45c1cf167757366193ad4a04df1d0020f5c789 it was just 1 loc