search

radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
218 stars 62 forks source link

meson.build: bump version #154

Closed ret2libc closed 6 years ago

ret2libc commented 6 years ago

A bit more explanation in the commits.

ret2libc commented 6 years ago

Install headers in the /usr/include/sdb/ subdirectory. This is also true when sdb is installed within radare. With make, headers are installed in /usr/include/libr/sdb, while with this PR (together with https://github.com/radare/radare2/pull/10863) they would be installed in /usr/include/sdb, which i believe makes more sense if sdb is ever going to be reused for other projects.

ret2libc commented 6 years ago

do not merge yet, still working on it

ret2libc commented 6 years ago

I think this looks good enough now :)

ret2libc commented 6 years ago

Actually before merging I want to check a thing

ret2libc commented 6 years ago

Ok I adapted a bit the things after thinking more about this and asking for help from others.

When sdb will be installed standalone (it's still not possible with meson, but i plan to make it possible soon), headers will be installed in /usr/include/sdb. When instead the meson.build is called as a "subproject", headers are not installed and we leave the choice to whoever is bundling sdb to choose where to installed it (e.g. radare2 will install the headers in /usr/include/libr/sdb).

ret2libc commented 6 years ago

Btw, this is now ready for review @radare

ret2libc commented 6 years ago

Closing it for now since I won't have time to see if anything bad happens because I'll go on vacation soon.