Closed thestr4ng3r closed 5 years ago
Lets just prefix it with r coz we own this letter
On 5 Oct 2018, at 19:13, Riccardo Schirone notifications@github.com wrote:
@ret2libc commented on this pull request.
In src/base64.c:
@@ -10,7 +10,7 @@ static const char cb64[]="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; static const char cd64[]="|$$$}rstuvwxyz{$$$$$$$>?@ABCDEFGHIJKLMNOPQRSTUVW$$$$$$XYZ[\]^_`abcdefghijklmnopq";
-static void b64_encode(const ut8 in[3], char out[4], int len) { +static void _b64encode(const ut8 in[3], char out[4], int len) { they told me it's better to avoid names that start with or __
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
I used sdb_
. Is that fine too?
Yeah sgtm
Solaris has its own b64_encode and b64_decode functions, which the ones here can conflict with: