search

radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
218 stars 62 forks source link

Windows&Unicode fix, fixed heap corruption #170

Closed a1ext closed 5 years ago

a1ext commented 5 years ago

Related to radareorg/cutter#589 fixed heap corruption in SDB fixed proper project saving on windows

radare commented 5 years ago

Thanks!

a1ext commented 5 years ago

you are welcome

radare commented 5 years ago

sgtm

On 29 Oct 2018, at 22:06, a1ext notifications@github.com wrote:

@a1ext commented on this pull request.

In src/disk.c https://github.com/radare/sdb/pull/170#discussion_r229098739:

static bool r_sysmkdir(char *path) { LPTSTR path = r_sys_conv_utf8_toutf16 (path); bool ret = CreateDirectory (path, NULL);

  • free (path);
  • free (path_); Also, I think it's better to make it impossible to build it on windows without turned on unicode support...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/sdb/pull/170#discussion_r229098739, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ltM7H_nrngJ8YSXlrSdLL6hHQa06ks5up23MgaJpZM4X_EEV.